search

cockroachdb / c-rocksdb

🚫 DEPRECATED
45 stars 19 forks source link

attempt to support windows #9

Closed tamird closed 8 years ago

tamird commented 9 years ago

Review on Reviewable

bdarnell commented 9 years ago

How have you tested this? If we're going to attempt to support windows, appveyor.com is a good windows-based CI platform (and you can set up multiple CI systems with github; I do this for Tornado).

However, this seems like an unnecessary distraction as we're approaching beta and we should wait to explore this until post-beta.

tamird commented 9 years ago

Yes, I agree. I was trying to get cross-compilation working using https://github.com/karalabe/xgo, and wanted to document what I had tried. I won't be actively working on this.

tamird commented 9 years ago

I should mention that this currently fails in xgo: https://github.com/karalabe/xgo/issues/26

petermattis commented 9 years ago

LGTM

tamird commented 8 years ago

Hey, this is ready for another look. For now, I've worked around some issues by omitting snappy on windows. This compiles successfully with xgo -go 1.6.1 --targets=windows-6.0/amd64 ..

tbg commented 8 years ago

:lgtm:, but with a healthy dose of science dog.

Previously, tamird (Tamir Duberstein) wrote… > Hey, this is ready for another look. For now, I've worked around some issues by omitting snappy on windows. This compiles successfully with `xgo -go 1.6.1 --targets=windows-6.0/amd64 .`. >

Reviewed 6 of 8 files at r1, 6 of 6 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable