search

cockroachdb / cockroach-go

Packages for go clients.
Apache License 2.0
160 stars 70 forks source link

set cmd.Dir to stop directory pollution #135

Closed chrisseto closed 2 years ago

chrisseto commented 2 years ago 
Previously, invocations of TestServer would results in various _dump
directories being created by the cockroachdb process. While these
directories were empty, it was bothersome to see them created and
show up in file exporers. This commit sets cmd.Dir to a temporary
directory to avoid polluting the project directory of consumers.
cockroach-teamcity commented 2 years ago

This change is Reviewable

rafiss commented 2 years ago

I need to figure out why CI is broken... Trying in https://github.com/cockroachdb/cockroach-go/pull/132

chrisseto commented 2 years ago

Fixed! I used github's auto rebase which apparently does a merge. TIL.

chrisseto commented 2 years ago

TFTR!