cockroachdb / cockroach-go

Packages for go clients.
Apache License 2.0
159 stars 70 forks source link

Support custom host on listen address #159

Closed pawalt closed 1 year ago

pawalt commented 1 year ago

Previously, the testserver could only listen on localhost. This meant that there was no way to spin up an instance of the testserver on one machine and access it from another. This commit adds support for custom hosts so that the testserver can be accessed from outside hosts if needed.

For my use case, I need this so that I can have a docker-compose file with two services: one for the testserver and one for my go tests. For the networking to work out, I need to be able to listen on 0.0.0.0 not localhost.

cockroach-teamcity commented 1 year ago

This change is Reviewable

pawalt commented 1 year ago

TFTR!