search

cockroachdb / cockroach-go

Packages for go clients.
Apache License 2.0
160 stars 70 forks source link

Custom cockroach binary via env variable #84

Closed georgysavva closed 4 years ago

georgysavva commented 4 years ago

This adds the ability to specify a custom cockroach binary via COCKROACH_BINARY env variable. Existing --cockroach-binary flag has more priority than the new env variable. See: https://github.com/cockroachdb/cockroach-go/issues/68

rafiss commented 4 years ago

LGTM! thank you. would you mind rebasing? master has the whitespace issue fixed and the logic was refactored.

georgysavva commented 4 years ago

Done.

georgysavva commented 4 years ago

Tests are failing (the same is in the master):

=== RUN   TestRunServer/SecureTenant
=== CONT  TestRunServer
    testserver_test.go:44: dial tcp 127.0.0.1:37305: connect: connection refused
cockroach-teamcity commented 4 years ago

This change is Reviewable

rafiss commented 4 years ago

It looks like that test is broken against cockroachdb master. Will skip for now, and I created https://github.com/cockroachdb/cockroach-go/issues/87

rafiss commented 4 years ago

I merged https://github.com/cockroachdb/cockroach-go/pull/88 which skips that test. Sorry for the hassle, but could you try rebasing again?

georgysavva commented 4 years ago

Sure, done!