Open tbg opened 1 year ago
Filed https://github.com/google/pprof/issues/769 upstream.
We should quick-fix on our end by avoiding the quotes, though.
Hacky work around:
git clone github.com:/cucaroach/pprof
cd pprof
go build -o crpprof
// usage, if you don't want to see pprof labels in svg...
PPROF_OMIT_NODELETS=y crpprof ...
Describe the problem
Make sure
graphviz
is installed. Download this profile, which was taken using the 23.1 test cluster,mv pprof.pb.gz{.txt,}
, thengo tool pprof -http :6060 pprof.pb.gz
. Then try to get the "Graph" view to work; it will instead printbut really the problem is that what
pprof
feeds todot
is not valid input:pprof.pb.gz.txt
To Reproduce
Output of
go tool pprof -dot pprof.pb.gz.txt > pprof.dot
is attached: pprof.dot.txtand this reproduces:
That line is the
range_str
label, which evidently isn't getting escaped properly:Short term, we should properly escape the range_str label, but really pprof should properly escape the tags, which would be an upstream contribution (which would then take a while to trickle into a Go distribution we'll eventually upgrade to). Arguably this is an upstream bug, will file it as such.
Jira issue: CRDB-26989