Closed cockroach-teamcity closed 1 year ago
Same as #101599
show_create_test.go:105: ALTER TABLE defaultdb.public."ta ble4" RENAME COLUMN crdb_internal_mvcc_timestamp TO col1
==================
WARNING: DATA RACE
Write at 0x0000120f3aa0 by goroutine 40106:
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc.(*Mutable).RenameColumnDescriptor()
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc/structured.go:1203 +0x9c
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc.RenameColumnInTable()
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc/table.go:603 +0xce8
github.com/cockroachdb/cockroach/pkg/sql.(*planner).renameColumn()
github.com/cockroachdb/cockroach/pkg/sql/rename_column.go:152 +0x198
github.com/cockroachdb/cockroach/pkg/sql.(*alterTableNode).startExec()
github.com/cockroachdb/cockroach/pkg/sql/alter_table.go:758 +0x2ab9
github.com/cockroachdb/cockroach/pkg/sql.startExec.func2()
github.com/cockroachdb/cockroach/pkg/sql/plan.go:518 +0x186
github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visitInternal.func1()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:112 +0xa9
runtime.deferreturn()
GOROOT/src/runtime/panic.go:476 +0x32
github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visit()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:79 +0x135
github.com/cockroachdb/cockroach/pkg/sql.walkPlan()
github.com/cockroachdb/cockroach/pkg/sql/walk.go:43 +0x165
github.com/cockroachdb/cockroach/pkg/sql.startExec()
github.com/cockroachdb/cockroach/pkg/sql/plan.go:521 +0x180
github.com/cockroachdb/cockroach/pkg/sql.(*planNodeToRowSource).Start()
github.com/cockroachdb/cockroach/pkg/sql/plan_node_to_row_source.go:172 +0x15c
github.com/cockroachdb/cockroach/pkg/sql/colexec.(*Columnarizer).Init()
github.com/cockroachdb/cockroach/pkg/sql/colexec/columnarizer.go:183 +0x17e
github.com/cockroachdb/cockroach/pkg/sql/colexec.(*invariantsChecker).Init()
github.com/cockroachdb/cockroach/pkg/sql/colexec/invariants_checker.go:67 +0xa3
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*batchInfoCollector).init()
github.com/cockroachdb/cockroach/pkg/sql/colflow/stats.go:94 +0x72
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*batchInfoCollector).init-fm()
<autogenerated>:1 +0x39
github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError()
github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92 +0x75
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*batchInfoCollector).Init()
github.com/cockroachdb/cockroach/pkg/sql/colflow/stats.go:103 +0xd3
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*vectorizedStatsCollectorImpl).Init()
<autogenerated>:1 +0x4b
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*BatchFlowCoordinator).init.func1()
github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:246 +0x6b
github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError()
github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92 +0x75
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*BatchFlowCoordinator).init()
github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:245 +0x70
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*BatchFlowCoordinator).Run()
github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:285 +0x2b8
github.com/cockroachdb/cockroach/pkg/sql/colflow.(*vectorizedFlow).Run()
github.com/cockroachdb/cockroach/pkg/sql/colflow/vectorized_flow.go:326 +0x349
github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:902 +0x1555
github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRun()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1913 +0x2e7
github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRunAll.func3()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1645 +0x144
github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRunAll()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1648 +0x2fd
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithDistSQLEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2095 +0xe24
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1648 +0x1fe6
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1478 +0xbf8
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:963 +0x638c
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:141 +0x18e
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithProfiling()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2984 +0x50f
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:140 +0x724
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2169 +0x7e4
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2174 +0x1d64
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1648 +0x1fe6
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:963 +0x638c
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:141 +0x18e
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithProfiling()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2984 +0x50f
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:140 +0x724
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2169 +0x7e4
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2174 +0x1d64
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:891 +0x1be
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommandsAsync.func1()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:766 +0x607
Previous read at 0x0000120f3aa0 by goroutine 42228:
github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb.(*ColumnDescriptor).ColName()
github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb/pkg/sql/catalog/descpb/column.go:37 +0x75
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc.column.ColName()
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc/column.go:86 +0x65
github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc.(*column).ColName()
<autogenerated>:1 +0x29
github.com/cockroachdb/cockroach/pkg/sql.newOptTable()
github.com/cockroachdb/cockroach/pkg/sql/opt_catalog.go:838 +0x360a
github.com/cockroachdb/cockroach/pkg/sql.(*optCatalog).dataSourceForTable()
github.com/cockroachdb/cockroach/pkg/sql/opt_catalog.go:541 +0x366
github.com/cockroachdb/cockroach/pkg/sql.(*optCatalog).dataSourceForDesc()
github.com/cockroachdb/cockroach/pkg/sql/opt_catalog.go:481 +0xfb
github.com/cockroachdb/cockroach/pkg/sql.(*optCatalog).ResolveDataSource()
github.com/cockroachdb/cockroach/pkg/sql/opt_catalog.go:248 +0x3fc
github.com/cockroachdb/cockroach/pkg/sql/opt.(*Metadata).CheckDependencies()
github.com/cockroachdb/cockroach/pkg/sql/opt/metadata.go:384 +0x1672
github.com/cockroachdb/cockroach/pkg/sql/opt/memo.(*Memo).IsStale()
github.com/cockroachdb/cockroach/pkg/sql/opt/memo/memo.go:375 +0x2449
github.com/cockroachdb/cockroach/pkg/sql.(*planner).prepareUsingOptimizer()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:138 +0x12eb
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).populatePrepared()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:314 +0x4ca
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).prepare.func2()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:266 +0x8ad
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).prepare()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:271 +0x4c1
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).addPreparedStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:115 +0x15a
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execPrepare()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:76 +0x5f3
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2284 +0x18a8
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2091 +0x424
github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).runWithEx.func1()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:175 +0x117
Goroutine 40106 (running) created at:
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommandsAsync()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:675 +0x3c4
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:392 +0xd15
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).serveConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:177 +0x48c
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*Server).ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/server.go:814 +0xc0a
github.com/cockroachdb/cockroach/pkg/server.(*systemServerWrapper).serveConn()
github.com/cockroachdb/cockroach/pkg/server/server_controller_sql.go:93 +0x1fa
github.com/cockroachdb/cockroach/pkg/server.(*serverController).sqlMux()
github.com/cockroachdb/cockroach/pkg/server/server_controller_sql.go:73 +0x4fc
github.com/cockroachdb/cockroach/pkg/server.(*serverController).sqlMux-fm()
<autogenerated>:1 +0xc7
github.com/cockroachdb/cockroach/pkg/server.startServeSQL.func1.1()
github.com/cockroachdb/cockroach/pkg/server/server_sql.go:1755 +0x2eb
github.com/cockroachdb/cockroach/pkg/util/netutil.(*TCPServer).ServeWith.func1()
github.com/cockroachdb/cockroach/pkg/util/netutil/net.go:188 +0x111
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:470 +0x1f6
Goroutine 42228 (running) created at:
github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).runWithEx()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:174 +0x345
github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).execInternal()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1015 +0x1311
github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).queryInternalBuffered()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:577 +0x24b
github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).QueryBufferedEx()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:546 +0x119
github.com/cockroachdb/cockroach/pkg/sql.(*internalTxn).QueryBufferedEx()
<autogenerated>:1 +0x33
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).servePauseAndCancelRequests.func1()
github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:551 +0x3b6
github.com/cockroachdb/cockroach/pkg/sql.(*internalDBWithOverrides).Txn.func1()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1749 +0xfe
github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).Txn.func1()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1604 +0x58
github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).txn.func4()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1682 +0x478
github.com/cockroachdb/cockroach/pkg/kv.runTxn.func1()
github.com/cockroachdb/cockroach/pkg/kv/db.go:965 +0x51
github.com/cockroachdb/cockroach/pkg/kv.(*Txn).exec()
github.com/cockroachdb/cockroach/pkg/kv/txn.go:928 +0xb0
github.com/cockroachdb/cockroach/pkg/kv.runTxn()
github.com/cockroachdb/cockroach/pkg/kv/db.go:964 +0x90
github.com/cockroachdb/cockroach/pkg/kv.(*DB).TxnWithAdmissionControl()
github.com/cockroachdb/cockroach/pkg/kv/db.go:927 +0xf0
github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn()
github.com/cockroachdb/cockroach/pkg/kv/db.go:902 +0x51
github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn-fm()
<autogenerated>:1 +0x64
github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).txn()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1670 +0x5fa
github.com/cockroachdb/cockroach/pkg/sql.(*InternalDB).Txn()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1605 +0xf0
github.com/cockroachdb/cockroach/pkg/sql.(*internalDBWithOverrides).Txn()
github.com/cockroachdb/cockroach/pkg/sql/internal.go:1745 +0x145
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).servePauseAndCancelRequests()
github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:541 +0x129
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).Start.func3()
github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1040 +0x85
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).Start.func4()
github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1047 +0xb0
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).withSession()
github.com/cockroachdb/cockroach/pkg/jobs/registry.go:995 +0x301
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).Start.func11()
github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1011 +0x52
github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).Start.func8()
github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1129 +0x456
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:470 +0x1f6
==================
pkg/ccl/testccl/sqlccl/sqlccl_test.TestShowCreateRedactableValues failed with artifacts on release-23.1 @ b04c9d1b1ed4c047162a8fc9cb44c46e3fe94201:
Parameters:
TAGS=bazel,gss,race
Help
See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)
Same failure on other branches
- #101599 pkg/ccl/testccl/sqlccl/sqlccl_test: TestShowCreateRedactableValues failed [C-test-failure GA-blocker O-robot branch-release-23.1.0]
/cc @cockroachdb/sql-queries
This test on roachdash | Improve this report!
Jira issue: CRDB-27389