cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.52k stars 3.7k forks source link

server: tenants should read their own timeseries without capabilities + can_view_tsdb_metrics capability should control access to storage-level metrics #102378

Open aadityasondhi opened 1 year ago

aadityasondhi commented 1 year ago

Is your feature request related to a problem? Please describe.

In the first implementation of the can_view_tsdb_metrics, the following behavior was implemented:

This is overly restrictive.

Describe the solution you'd like

Also as a result we will probably want to rename that capability to can_view_storage_metrics.

Additional context

Jira issue: CRDB-27417 Epic CRDB-34076

rafiss commented 10 months ago

This is referenced as a skipped test here: https://github.com/cockroachdb/cockroach/blob/60fa6c0b8521b103da81bd967f0335c1d9503418/pkg/server/authserver/authentication_test.go#L777