search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.19k stars 3.82k forks source link

performance regression in execStmtInOpenState #102398

Open srosenberg opened 1 year ago

srosenberg commented 1 year ago

Split from https://github.com/cockroachdb/cockroach/issues/101299

A performance regression of ~3-5% was observed in execStmtInOpenState. The flamegraphs below suggest the regression was caused by [1].

Before the change (baseline commit is a3d53668ff5),

execStmtInOpenState_before

After the change,

execStmtInOpenState_after

[1] https://github.com/cockroachdb/cockroach/pull/99663

Jira issue: CRDB-27421

srosenberg commented 1 year ago

@cockroachdb/sql-sessions

rafiss commented 1 year ago

@ecwall since you're on call right now, could you pick this up to see where the extra time is being spent? depending on what you find, we can work on a fix now, or plan the work for later.

ecwall commented 1 year ago

Reproduction steps here https://github.com/cockroachdb/cockroach/issues/101299#issuecomment-1520466940

Note:

be careful with the workload gen.; best to build it from master because there was a previously known regression which limits workload’s throughput generation.