cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

tracing: add trace events to all the http endpoints #107949

Open j82w opened 1 year ago

j82w commented 1 year ago

The goal is to create a similar event to SampledQuery, but for http calls.

Goals:

  1. Capture overall latency.
  2. Capture request details. To help understand what options were requested to understand why a request behaved a certain way.
  3. Record all failures.
  4. Capture stats for individual calls in the http endpoint to understand what is the cause of the latency.
  5. Be able capture these events in splunk/snowflake/etc.. other external observability systems to be able to monitor and troubleshoot the http endpoints.

Related issue: https://github.com/cockroachdb/cockroach/issues/94250

Jira issue: CRDB-30270

Epic CRDB-32402

kevin-v-ngo commented 1 year ago

Capture stats for individual calls in the http endpoint to understand what is the cause of the latency.

Are these the same stats as the SQL stats we have today in SampledQuery? It'd be helpful if it was and/or we provide some correlation with the sampled_query event.

maryliag commented 1 year ago

No longer a priority