search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.87k stars 3.77k forks source link

rangefeed: clean up task code #108694

Open erikgrinaker opened 1 year ago

erikgrinaker commented 1 year ago

We have some code in kvserer/rangefeed/task.go which should be cleaned up. It implementes a runnable interface that isn't really used anywhere, and it's tightly coupled with the processor (soon via a processorTaskHelper interface). I think the task idea may possibly be a historical vestige of some former structure. We should restructure these more like standalone helper functions, where the processor itself takes action based on the outcome of the functions.

See https://github.com/cockroachdb/cockroach/pull/107377#pullrequestreview-1565075260.

Jira issue: CRDB-30596

Epic CRDB-39959

blathers-crl[bot] commented 1 year ago

cc @cockroachdb/replication