changefeedccl: order validator does not assert monotonic resolved messages

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.

https://www.cockroachlabs.com

Other

30.15k stars 3.81k forks source link

changefeedccl: order validator does not assert monotonic resolved messages #108872

Open jayshrivastava opened 1 year ago

jayshrivastava commented 1 year ago

We should probably assert in the order validator (which is used in roachtests, changefeed nemeses etc) that resolved messages are monotonic. You should never see a regression in the resolved messages.

I started a draft PR https://github.com/cockroachdb/cockroach/pull/108861. C2C streaming tests fail because you see resolved messages that go back in time. I don't know if this is expected for streaming. Nevertheless, the PR needs a bit more work.

Jira issue: CRDB-30676

blathers-crl[bot] commented 1 year ago

cc @cockroachdb/cdc

Shwepoo commented 3 weeks ago

@rharding6373 Hi there! I'd like to pick up this issue and contribute towards resolving it. I have experience working with Go (Golang), and I believe I can help address this effectively.

Could you please provide any additional context or guidelines that I should follow? Looking forward to contributing and collaborating on this.

Thank you!