Closed cockroach-teamcity closed 1 year ago
This appears unrelated to the specific test itself. Instead, the race condition is hit within the serverController
itself when dealing with the testArgs
, which aren't protected by a mutex: https://github.com/cockroachdb/cockroach/blob/d9f6b1a99554ce2f9df111732b8de39947c7e988/pkg/server/server_controller.go#L75-L76
The TestServer writes to this map when starting shared process tenants, and the server controller orchestrator reads from it when instantiating a new server.
Seems like we can just move the testArgs map to be protected by the existing mutex used by the serverController
to solve this.
pkg/util/tracing/collector/collector_test.TestClusterInflightTraces failed with artifacts on master @ 7164cadbe45f479fb9e6f3296f287fa7492804f0:
Parameters:
TAGS=bazel,gss,race
,stress=true
Help
See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)
/cc @cockroachdb/obs-inf-prs
This test on roachdash | Improve this report!
Jira issue: CRDB-30939