Closed shralex closed 9 months ago
Hi @shralex, please add branch-* labels to identify which branch(es) this release-blocker affects.
:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.
The initial test on this was not looking good - there was a big performance hit when making a "no-op" span config change on a system with 2M ranges. I didn't capture CPU and it was hard to reproduce.
I reran this test on a cluster without rangefeeds and running at a "normal" usage level. I grabbed a few CPU profiles before and after running the change, and watched the latency. There was no noticeable change in P99 latency and the CPU profiles looked good.
We've recently made a change where we only enqueue updates that aren't a PTS change. The remaining question is the cost of this check.
Jira issue: CRDB-32087