kv: update TestGossipHandlesReplacedNode to handle port reuse

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.

https://www.cockroachlabs.com

Other

30.15k stars 3.81k forks source link

kv: update TestGossipHandlesReplacedNode to handle port reuse #114036

Open andrewbaptist opened 1 year ago

andrewbaptist commented 1 year ago

Currently TestGossipHandlesReplacedNode can fail due to reusing a port. This has been addressed by skipping the test if this occurs, but this can potentially mask real failures that could happen.

This is just an issue to remember to clean this test up.

Jira issue: CRDB-33311

pav-kv commented 5 months ago

We have reusable listeners in tests now, so should be an easy fix. Example: #108897.

blathers-crl[bot] commented 5 months ago

Hi @pav-kv, please add branch-* labels to identify which branch(es) this C-bug affects.

_{:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

pav-kv commented 3 months ago

There is a bug in this test skipping logic. Fixing the skipping logic in #128670 to get rid of test flaking spam, but we still need to address the root cause and fix the port reuse in this test.