search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.97k stars 3.79k forks source link

kvserver: consistency checker prints self in set of all replicas #114418

Open nicktrav opened 10 months ago

nicktrav commented 10 months ago

When the consistency checker fires, it prints a message of the following form:

[n41,s404,r1081383/5:‹/Table/106/1/15822{257…-339…}›]
and its other replicas: (n39,s382):6,(n41,s404):5,(n18,s189):4

We print r1081383/5, but it also appears in the slice of "other replicas". This is mildly confusing / annoying.

Instead, we could do something like a set subtraction of "self" from its replicas.

More context (internal).

Jira issue: CRDB-33504

Epic CRDB-39898

blathers-crl[bot] commented 10 months ago

cc @cockroachdb/replication