search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.08k stars 3.8k forks source link

Transition from AWS SDK V1 to V2 #116320

Closed udnay closed 1 month ago

udnay commented 10 months ago

CRDB currently uses the AWS SDK V1 for go which does not support some features, for example multi-region access points for s3.

CRDB already uses AWS SDK V2 for some DMS integrations and testing.

Describe the solution you'd like We standardize S3 and KMS access through V2 of the SDK and remove V1 of the SDK. We would need to migrate s3_storage.go and aws_kms.go plus tests over to the new SDK.

Jira issue: CRDB-34577

adityamaru commented 10 months ago

I'm not sure we want this marked as quick-win/starter, this is on the DR roadmap for 24.1 and have chalked out time to work on it early on in the release.

blathers-crl[bot] commented 10 months ago

cc @cockroachdb/disaster-recovery

andrewbaptist commented 10 months ago

Makes sense! I didn't realize this was on a roadmap. It seemed "self contained" enough that it might have been a good project. We are trying to tag these types of issues in KV to have projects for either community contributions or new engineers/interns.

adityamaru commented 9 months ago

This is almost done in https://github.com/cockroachdb/cockroach/pull/115628, I'm going to tentatively reassign this to @stevendanna since he was reviewing the PR.

blathers-crl[bot] commented 8 months ago

Hi @msbutler, please add branch-* labels to identify which branch(es) this GA-blocker affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.