search

cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.58k stars 3.71k forks source link

batcheval: rate limit the scan in RecomputeStats #119501

Open miraradeva opened 4 months ago

miraradeva commented 4 months ago

As a result of #119499, potentially many more ranges will have their stats re-computed as part of the consistency checker queue processing. The invocations of RecomputeStats from the consistency checker are rate-limited so we don't have bursts of re-computation for all ranges. But within a single call to RecomputeStats, the underlying scan is not rate-limited.

We should do something similar to the consistencyLimiter.

Jira issue: CRDB-36260

blathers-crl[bot] commented 3 months ago

Hi @miraradeva, please add branch-* labels to identify which branch(es) this GA-blocker affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

miraradeva commented 3 months ago

Discussed and decided there is no immediate need to do this work: stats re-computation has not been causing stability issues. Adding rate limiting late in the release cycle may lead to more instability: e.g. splits taking significantly longer.