cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.99k stars 3.79k forks source link

roachtest: regenerate BACKUP fixtures for TPCC/TPCH tests #120146

Open rafiss opened 7 months ago

rafiss commented 7 months ago

In this thread, we realized that TPCC and TPCH test fixtures use backups that are several years old: https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1709912020888919?thread_ts=1709896031.584779&cid=C023S0V4YEB

We no longer support restoring from backups taken from more than 1 major version ago. (Or 2, if we're in a branch that supports version skipping.)

We should regenerate the fixtures.

https://github.com/cockroachdb/cockroach/issues/120124 is an example of a failure that was caused by this, with many other issues linked to it.

https://github.com/cockroachdb/cockroach/pull/120147 works around this issue by adding a post-restore descriptor change, so tests stop failing, but we still should tackle this tech debt and update the fixtures.

Jira issue: CRDB-36509

blathers-crl[bot] commented 7 months ago

cc @cockroachdb/test-eng