roachprod: update & get latest no longer works

herkolategan commented 7 months ago

Some builds have recently started migrating to EngFlow [1]. This causes the logic we currently use in roachprod and the ./scripts/roachprod-get-latest.sh to fail. It results in a "binary" containing the "Not Found" HTTP page.

# cat roachprod
...
  <title>Not found</title>
</head>
<body>
  <div class="errorPage">
    <div
        class="errorPage__image"
        title="Page not found"

And from roachprod

# ./bin/roachprod update
Downloading roachprod from: https://teamcity.cockroachdb.com/guestAuth/app/rest/builds/id:14470406/artifacts/content/bazel-bin/pkg/cmd/roachprod/roachprod_/roachprod
Error: UNCLASSIFIED_PROBLEM: bad status downloading roachprod: 404 Not Found
(1) UNCLASSIFIED_PROBLEM
Wraps: (2) bad status downloading roachprod: 404 Not Found
Error types: (1) errors.Unclassified (2) *errors.errorString

From the script the binaries are being pulled from: TC_BASE="https://teamcity.cockroachdb.com/repository/download"

These will need to be updated to pull from EngFlow or wherever these will be available.

* This is technically a bug, but it is not widely used, hence marking it as an enhancement for now.

Update: roachprod update now works on Linux, but not Darwin. See this thread.

[1] https://github.com/cockroachdb/cockroach/pull/120252

Jira issue: CRDB-36855

blathers-crl[bot] commented 7 months ago

cc @cockroachdb/test-eng

blathers-crl[bot] commented 7 months ago

cc @cockroachdb/test-eng

cockroachdb / cockroach

roachprod: update & get latest no longer works #120750