The webhook v1 and cloud storage sinks both execute a callback to update the changefeed.flush_hist_nanos metric immediately, which is inaccurate. For webhook, the callback should be deferred. In the cloud storage sink, we already execute a callback in the async flush code path, so we could eliminate the bad callback and instead add one on the sync flush code path.
blathers-crl[bot]
commented
6 months ago
The webhook v1 and cloud storage sinks both execute a callback to update the
changefeed.flush_hist_nanosmetric immediately, which is inaccurate. For webhook, the callback should be deferred. In the cloud storage sink, we already execute a callback in the async flush code path, so we could eliminate the bad callback and instead add one on the sync flush code path.Jira issue: CRDB-37153
Epic CRDB-37337