pkg/sql/sqlstats/sslocal/sslocal_test: TestTransactionServiceLatencyOnExtendedProtocol failed

[cockroach-teamcity]

pkg/sql/sqlstats/sslocal/sslocal_test.TestTransactionServiceLatencyOnExtendedProtocol failed with artifacts on release-23.1 @ 22e316ca6f040a38fd5e4fd70cdee4b6c4617c62:

      pkg/sql/sqlstats/sslocal/sslocal_test_test/pkg/sql/sqlstats/sslocal/sql_stats_test.go:782 +0xf0c
  github.com/cockroachdb/cockroach/pkg/server.(*Server).PreStart()
      github.com/cockroachdb/cockroach/pkg/server/server.go:1936 +0x4fe4
  github.com/cockroachdb/cockroach/pkg/server.(*TestServer).Start()
      github.com/cockroachdb/cockroach/pkg/server/testserver.go:617 +0x8f
  github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServer()
      github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_server_shim.go:328 +0x1b6
  github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServer()
      github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_server_shim.go:323 +0x96
  pkg/sql/sqlstats/sslocal/sslocal_test_test.TestTransactionServiceLatencyOnExtendedProtocol()
      pkg/sql/sqlstats/sslocal/sslocal_test_test/pkg/sql/sqlstats/sslocal/sql_stats_test.go:759 +0xa7c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47

Goroutine 22558 (running) created at:
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).runWithEx()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:174 +0x345
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).execInternal()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:1038 +0x13b1
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).QueryIteratorEx()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:730 +0x29a
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).QueryIterator()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:716 +0x13e
  github.com/cockroachdb/cockroach/pkg/server.(*serverController).getExpectedRunningTenants()
      github.com/cockroachdb/cockroach/pkg/server/server_controller_orchestration.go:195 +0x1ea
  github.com/cockroachdb/cockroach/pkg/server.(*serverController).scanTenantsForRunnableServices()
      github.com/cockroachdb/cockroach/pkg/server/server_controller_orchestration.go:106 +0xa8
  github.com/cockroachdb/cockroach/pkg/server.(*serverController).start.func1()
      github.com/cockroachdb/cockroach/pkg/server/server_controller_orchestration.go:60 +0x21a
  github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
      github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:470 +0x1f6

Goroutine 20251 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1726 +0xa84
  pkg/sql/sqlstats/sslocal/sslocal_test_test.TestMain()
      pkg/sql/sqlstats/sslocal/sslocal_test_test/pkg/sql/sqlstats/sslocal/main_test.go:28 +0x186
  main.main()
      main/bazel-out/k8-fastbuild/bin/pkg/sql/sqlstats/sslocal/sslocal_test_/testmain.go:142 +0x748
==================

Parameters:

• TAGS=bazel,gss,race
  Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/obs-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-37847

[abarganier]

Removing the release-blocker label.

This is failing due to a data race in the test code.

@dhartunian fixed this earlier in https://github.com/cockroachdb/cockroach/pull/120419.

We just need to backport to the release-23.1 branch.

[abarganier]

https://github.com/cockroachdb/cockroach/pull/122465 has been merged. Closing.