Open rharding6373 opened 1 month ago
cc @cockroachdb/cdc
We should also consider that we'd like to deprecate older sink versions, and whatever option we choose here could affect our ability to deprecate the old version of pubsub (if customers prefer to remain on the old syntax).
Downgrading priority to P-3, since we now have documentation to warn users about this breaking change. Keeping this open to consider making the naming consistent across sinks.
In pubsub v1, changefeeds with json encoders emitted events of the form
{key: ..., value: ..., topic: ...}
(all lowercase). In pubsub v2, this format was changed to{Key: ..., Value: ..., Topic: ...}
(capitalized), which is a breaking change. Specifically, if customers are upgrading from 23.1, where pubsub v2 is disabled by default, or an earlier version to 23.2 or later, where pubsub v2 is enabled by default, downstream systems can break because they're unable to parse the new syntax.We should either:
changefeed.new_pubsub_sink_enabled
to true.Jira issue: CRDB-38589