search

cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.52k stars 3.7k forks source link

kvcoord: improve logging in mux rangefeed #125669

Open arulajmani opened 3 weeks ago

arulajmani commented 3 weeks ago

Is your feature request related to a problem? Please describe.

Currently, all of the logging in dist_sender_mux_rangefeed.go is behind a verbosity flag. It makes debugging issues like https://github.com/cockroachlabs/support/issues/2980, where we want to answer questions about why we weren't able to establish a rangefeed hard. We should consider logging failure/retry scenarios normally; if these prove to be too verbose, maybe we can only log after x attempts and/or introduce a new logging channel here.

cc @wenyihu6

Jira issue: CRDB-39545

blathers-crl[bot] commented 3 weeks ago

cc @cockroachdb/cdc

rharding6373 commented 3 weeks ago

KV owns rangefeeds and this doesn't seem related to the current rangefeed scalability work.