cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.92k stars 3.78k forks source link

changefeedccl: warn or error when user specifies `resolved` < `min_checkpoint_frequency` #125884

Open andyyang890 opened 3 months ago

andyyang890 commented 3 months ago

We already have a strongly-worded note in our public docs saying that the user should take care to make sure that min_checkpoint_frequency <= resolved since we won't emit resolved timestamps more frequently than min_checkpoint_frequency. We should either enforce this condition in code or at least issue a warning if the user violates this.

One argument against making this an error would be that it could be a breaking change for existing changefeeds.

Jira issue: CRDB-39646

blathers-crl[bot] commented 3 months ago

cc @cockroachdb/cdc