cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.13k stars 3.81k forks source link

cmd: sync cockroach-sql flags with cockroach sql #125939

Open annrpom opened 4 months ago

annrpom commented 4 months ago

Is your feature request related to a problem? Please describe. Our docs state the following:

the cockroach-sql command is a client for executing SQL statements from an interactive shell or directly from the command line. cockroach-sql is functionally equivalent to the cockroach sql command.

However, there are many flags that cockroach sql supports that cockroach-sql does not. For instance, the --format flag works as expected with cockroach sql:

anniepompa in ~/go/src/github.com/cockroachdb/cockroach on fp-debug-doctor-jobs ● ● λ cockroach sql --format=csv -e="select 1" --insecure
?column?
1

Time: 0ms

But with cockroach-sql:

anniepompa in ~/go/src/github.com/cockroachdb/cockroach on fp-debug-doctor-jobs ● ● λ ./cockroach-sql --format=csv -e="select 1" --insecure
ERROR: unknown flag: --format

This has been the case since cockroach-sql was been introduced (v22.1).

Describe the solution you'd like We should sync the flags

Jira issue: CRDB-39676

annrpom commented 4 months ago

In https://github.com/cockroachdb/cockroach/issues/123382, the --format flag was added in cockroach-sql for an O-support reason; however, we might want to consider syncing the rest of the flags