pkg/sql/schemachanger/schemachanger_test: TestExecuteWithDMLInjection_alter_table_add_check_vanilla failed

[cockroach-teamcity]

pkg/sql/schemachanger/schemachanger_test.TestExecuteWithDMLInjection_alter_table_add_check_vanilla failed with artifacts on release-24.2 @ 60d3fb84a73f5e31c99404223f3a0ba91e67f489:

    datadriven.go:144: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/13753/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_check_vanilla/alter_table_add_check_vanilla.definition:7:
        stage-exec [3 args]
        UPDATE t SET i=-4 WHERE i = 3;
        ----
    datadriven.go:144: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/13753/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_check_vanilla/alter_table_add_check_vanilla.definition:11:
        stage-exec [3 args]
        INSERT INTO t(i) VALUES(-$stageKey);
        INSERT INTO t(i) VALUES(-$stageKey - 1);
        ----
    datadriven.go:144: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/13753/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_check_vanilla/alter_table_add_check_vanilla.definition:16:
        stage-exec [2 args]
        INSERT INTO t(i) VALUES($stageKey);
        INSERT INTO t(i) VALUES($stageKey + 1);
        ----
    datadriven.go:144: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/13753/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_check_vanilla/alter_table_add_check_vanilla.definition:21:
        stage-exec [2 args]
        INSERT INTO t(i) VALUES(-1)
        ----
        pq: failed to satisfy CHECK constraint .*
    datadriven.go:144: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/13753/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/schemachanger/schemachanger_test_/schemachanger_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/schemachanger/testdata/end_to_end/alter_table_add_check_vanilla/alter_table_add_check_vanilla.definition:29:
        stage-query [2 args]
        SELECT count(*)=($successfulStageCount*2)+3 FROM t;
        ----
        true
    panic.go:626: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/dc5b925658b540a9548942f8f69cf9af/logTestExecuteWithDMLInjection_alter_table_add_check_vanilla3255001391
--- FAIL: TestExecuteWithDMLInjection_alter_table_add_check_vanilla (4.42s)
=== RUN   TestExecuteWithDMLInjection_alter_table_add_check_vanilla/injection_stage_{minOrdinal:1_maxOrdinal:2_phase:3_rollback:false}
    framework.go:487: query 'SELECT count(*)=($successfulStageCount*2)+3 FROM t' ($stageKey=(phase = PostCommitPhase stageOrdinal=1 rollback=false),$successfulStageCount=1): expected:
        true

        got:
        false

    cumulative.go:187: forcing job failure from BeforeStage due to test failure
    cumulative.go:182: short-circuiting BeforeStage hook due to test failure
    cumulative.go:242: 
            Error Trace:    github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest/cumulative.go:242
                                        github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest/test_server_factory.go:102
                                        github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest/cumulative.go:255
                                        github.com/cockroachdb/cockroach/pkg/sql/schemachanger/sctest/cumulative.go:151
            Error:          Received unexpected error:
                            pq: transaction committed but schema change aborted with error: (XXUUU): t.Failed() is true
            Test:           TestExecuteWithDMLInjection_alter_table_add_check_vanilla/injection_stage_{minOrdinal:1_maxOrdinal:2_phase:3_rollback:false}
    --- FAIL: TestExecuteWithDMLInjection_alter_table_add_check_vanilla/injection_stage_{minOrdinal:1_maxOrdinal:2_phase:3_rollback:false} (2.30s)

Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-40497

[rafiss]

We lost the test artifacts here. Let's leave this as a P-3 and pick this up when we have time to try to reproduce it more, and also see if the failure occurs again.

This previously failed in https://github.com/cockroachdb/cockroach/issues/123851 as well.

[github-actions[bot]]

We have marked this test failure issue as stale because it has been inactive for 1 month. If this failure is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 5 days to keep the test failure queue tidy.