ui: some metrics are incorrectly using store ids as the source instead of node ids

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.

https://www.cockroachlabs.com

Other

30.1k stars 3.81k forks source link

ui: some metrics are incorrectly using store ids as the source instead of node ids #127698

Closed xinhaoz closed 1 month ago

xinhaoz commented 3 months ago

In some metrics dashboards we provide the store id when we should be providing the node id, e.g.: https://github.com/cockroachdb/cockroach/blob/c7050a8fa2d6b64dd265767734d7ba792e1c6772/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/networking.tsx#L34.

This leads to incorrect and missing series on affected graphs.

Jira issue: CRDB-40556

blathers-crl[bot] commented 3 months ago

Hi @xinhaoz, please add branch-* labels to identify which branch(es) this C-bug affects.

_{:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

daniel-crlabs commented 1 month ago

I see this issue has been marked as closed and it has 3 tags: 23.2, 24.1 and 24.2. What specific minor versions will have these fixes and when will it be available for customers to download? One of our customers has this issue currently and we need to let them know what version they should upgrade to.