Saw a BenchmarkMVCCScan_Pebble failure in the Bazel Extended CI. It looks like we are reusing a cached fixture that was stamped with a non-dev version.
We currently include the pebble major format version in the key for the fixture; we should be including the full cluster version.
--- FAIL: BenchmarkMVCCScan_Pebble/rows=1/versions=1/valueSize=8/numRangeKeys=0
16:46:33 test_fixtures.go:90: using existing fixture "mvcc-fmtver_17-numKeys_100000-numVersions_1-valueBytes_8-numColFams_0-numRangeKeys_0" in "/home/roach/.cache/crdb-test-fixtures/mvcc-fmtver_17-numKeys_100000-numVersions_1-valueBytes_8-numColFams_0-numRangeKeys_0"
16:46:33 bench_data_test.go:106:
16:46:33 Error Trace: github.com/cockroachdb/cockroach/pkg/storage/bench_data_test.go:106
16:46:33 github.com/cockroachdb/cockroach/pkg/storage/bench_test.go:788
16:46:33 github.com/cockroachdb/cockroach/pkg/storage/bench_pebble_test.go:120
16:46:33 GOROOT/src/testing/benchmark.go:193
16:46:33 GOROOT/src/testing/benchmark.go:215
16:46:33 src/runtime/asm_amd64.s:1695
16:46:33 Error: Received unexpected error:
16:46:33 store last used with cockroach non-development version v23.2 cannot be opened by development version v1000024.1-upgrading-to-1000024.2-step-012
16:46:33 (1) attached stack trace
16:46:33 -- stack trace:
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage.newPebble
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage/pebble.go:1368
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage.Open
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage/open.go:564
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage.getInitialStateEngine
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage/bench_data_test.go:105
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage.runMVCCScan
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage/bench_test.go:788
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage.BenchmarkMVCCScan_Pebble.func1
16:46:33 | github.com/cockroachdb/cockroach/pkg/storage/bench_pebble_test.go:120
jbowens
commented
1 week ago
Saw a BenchmarkMVCCScan_Pebble failure in the Bazel Extended CI. It looks like we are reusing a cached fixture that was stamped with a non-dev version.
We currently include the pebble major format version in the key for the fixture; we should be including the full cluster version.
Jira issue: CRDB-40802