search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.11k stars 3.81k forks source link

REST API to set cluster settings #128965

Open massimocGH opened 2 months ago

massimocGH commented 2 months ago

Currently the cluster settings can only be set through the SQL command SET CLUSTER SETTING

It would be nice if the CockroachDB REST API (https://www.cockroachlabs.com/docs/stable/cluster-api) can allow to change the cluster setting from application code or a script without the need to have the sql driver installed.

Jira issue: CRDB-41307

rafiss commented 2 months ago

@massimocGH This work is not part of the SQL Foundations area. We aren't the owners of cluster settings or REST APIs. I'll tag the DB Server team on this for now instead.

Also, there aren't enough details here to say if a REST API is really the best way to solve the actual problem the customer had. Can you provide more details on the user story, or a link to the support case where this came up?

Since this is more of a feature request than a bug fix, I believe it would be better to file this through the TREQ process. Can you work with the account team for the customer who ran into this?

massimocGH commented 2 months ago

@rafiss , thanks for sending this to the correct team and apologies for setting the wrong one. The support case is linked to the internal jira CRDB-41307 Support use this process to request enhancements, but we can also request the account team to file a TREQ if the request is more critical which doesn't seem to be the case here.

rimadeodhar commented 2 months ago

From @BabuSrithar: We have received similar requests on authentication side as well. That will be the first step to enabling something like this. We would need to support auth through REST API and then provide access to this type of functionality.

rafiss commented 2 months ago

The server API already supports authentication with the login endpoint. But perhaps I misunderstood which other auth functionality was needed.

BabuSrithar commented 2 months ago

Here is related ticket that ended towards supporting JWT for DB Console APIs as a resolution to this requirement. https://cockroachlabs.atlassian.net/browse/CRDB-40211

This will be true to this requirement as well, to make the automation through API "complete".