search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.96k stars 3.79k forks source link

pkg/sql/logictest/tests/cockroach-go-testserver-upgrade-to-master/cockroach-go-testserver-upgrade-to-master_test: TestLogic_mixed_version_upgrade_repair_descriptors failed #131206

Open cockroach-teamcity opened 1 week ago

cockroach-teamcity commented 1 week ago

pkg/sql/logictest/tests/cockroach-go-testserver-upgrade-to-master/cockroach-go-testserver-upgrade-to-master_test.TestLogic_mixed_version_upgrade_repair_descriptors failed with artifacts on release-23.2.12-rc @ 8318cbdcece263f6f7b91cef346d75e6a35a50f9:

            GOROOT/src/os/exec/exec.go:717 +0x34
        created by os/exec.(*Cmd).Start in goroutine 11
            GOROOT/src/os/exec/exec.go:716 +0x7bc
        Leaked goroutine: goroutine 98 [IO wait, 1 minutes]:
        internal/poll.runtime_pollWait(0xffff424126f0, 0x72)
            GOROOT/src/runtime/netpoll.go:343 +0xa0
        internal/poll.(*pollDesc).wait(0x4003d074a0?, 0x4000064000?, 0x1)
            GOROOT/src/internal/poll/fd_poll_runtime.go:84 +0x28
        internal/poll.(*pollDesc).waitRead(...)
            GOROOT/src/internal/poll/fd_poll_runtime.go:89
        internal/poll.(*FD).Read(0x4003d074a0, {0x4000064000, 0x8000, 0x8000})
            GOROOT/src/internal/poll/fd_unix.go:164 +0x200
        os.(*File).read(...)
            GOROOT/src/os/file_posix.go:29
        os.(*File).Read(0x4001ba3f50, {0x4000064000?, 0x400000fcb0?, 0x0?})
            GOROOT/src/os/file.go:118 +0x70
        io.copyBuffer({0xffff3c3bcc98, 0x400000fcb0}, {0x642fca0, 0x4001ba3f50}, {0x0, 0x0, 0x0})
            GOROOT/src/io/io.go:430 +0x168
        io.Copy(...)
            GOROOT/src/io/io.go:389
        os/exec.(*Cmd).writerDescriptor.func1()
            GOROOT/src/os/exec/exec.go:560 +0x44
        os/exec.(*Cmd).Start.func2(0x0?)
            GOROOT/src/os/exec/exec.go:717 +0x34
        created by os/exec.(*Cmd).Start in goroutine 11
            GOROOT/src/os/exec/exec.go:716 +0x7bc
        Leaked goroutine: goroutine 99 [IO wait]:
        internal/poll.runtime_pollWait(0xffff42412500, 0x72)
            GOROOT/src/runtime/netpoll.go:343 +0xa0
        internal/poll.(*pollDesc).wait(0x4003d07560?, 0x4000e1e000?, 0x1)
            GOROOT/src/internal/poll/fd_poll_runtime.go:84 +0x28
        internal/poll.(*pollDesc).waitRead(...)
            GOROOT/src/internal/poll/fd_poll_runtime.go:89
        internal/poll.(*FD).Read(0x4003d07560, {0x4000e1e000, 0x8000, 0x8000})
            GOROOT/src/internal/poll/fd_unix.go:164 +0x200
        os.(*File).read(...)
            GOROOT/src/os/file_posix.go:29
        os.(*File).Read(0x4001ba3f68, {0x4000e1e000?, 0x400000fcc8?, 0x0?})
            GOROOT/src/os/file.go:118 +0x70
        io.copyBuffer({0xffff3c3bcc98, 0x400000fcc8}, {0x642fca0, 0x4001ba3f68}, {0x0, 0x0, 0x0})
            GOROOT/src/io/io.go:430 +0x168
        io.Copy(...)
            GOROOT/src/io/io.go:389
        os/exec.(*Cmd).writerDescriptor.func1()
            GOROOT/src/os/exec/exec.go:560 +0x44
        os/exec.(*Cmd).Start.func2(0x0?)
            GOROOT/src/os/exec/exec.go:717 +0x34
        created by os/exec.(*Cmd).Start in goroutine 11
            GOROOT/src/os/exec/exec.go:716 +0x7bc
--- FAIL: TestLogic_mixed_version_upgrade_repair_descriptors (70.41s)
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-42442

fqazi commented 6 days ago

The skipping logic we added for snappy errors isn't playing nice here (https://github.com/cockroachdb/cockroach/pull/130823):

    logic.go:1386: ignoring init did not finish for node error due to snappy error

After skipping the leak test fails. Assigning to @rafiss, since I wonder if we need to skip in some other way?