sql: code for encoding primary index entries is duplicated in multiple locations

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.

https://www.cockroachlabs.com

Other

29.96k stars 3.79k forks source link

Open stevendanna opened 9 hours ago

stevendanna commented 9 hours ago

Describe the problem

There are now at least 4 locations that all know the details of how to create values for a primary index given some descriptor:

It would be nice if some of this duplication could be removed. Or if we could at least get some unit tests around some of these implementations.

Jira issue: CRDB-42624

blathers-crl[bot] commented 9 hours ago

Hi @stevendanna, please add branch-* labels to identify which branch(es) this C-bug affects.

_{:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}