search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.1k stars 3.8k forks source link

kvserver/rangefeed: additional clean up after removing legacy processor #132843

Open wenyihu6 opened 2 weeks ago

wenyihu6 commented 2 weeks ago

Describe the problem

  1. Remove metrics since this was only used for legacy processor https://github.com/cockroachdb/cockroach/blob/661366d2c1d30ab1734748190c7610ed7b4ee373/pkg/kv/kvserver/rangefeed/metrics.go#L98.

  2. Address this comment https://github.com/cockroachdb/cockroach/blob/661366d2c1d30ab1734748190c7610ed7b4ee373/pkg/kv/kvserver/rangefeed/processor_test.go#L921-L925

  3. Check if we are confident with mixed version clusters between 24.3 and 25.1. It should be fine, as the scheduled-based processor operates independently on each node.

Jira issue: CRDB-43306

blathers-crl[bot] commented 2 weeks ago

Hi @wenyihu6, please add branch-* labels to identify which branch(es) this C-bug affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.