search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.06k stars 3.8k forks source link

roachtest: investigate existing ac tests and run any disabled ones to find regressions in rac2 #133413

Open kvoli opened 1 day ago

kvoli commented 1 day ago

As description states. There are several disabled by default admission control tests. This issue is to run them manually and compare the results between v24.2 and v24.3 with identical settings/constants/metamorphic etc.

Jira issue: CRDB-43592

Epic CRDB-37515

kvoli commented 8 hours ago

List of admission_control* tests from roachtest list:

admission-control/database-drop [admission-control]
admission-control/disk-bandwidth-limiter [admission-control]
admission-control/elastic-backup [admission-control]
admission-control/elastic-cdc [admission-control]
admission-control/elastic-io [admission-control]
admission-control/index-backfill [admission-control]
admission-control/index-overload [admission-control]
admission-control/intent-resolution [admission-control]
admission-control/multi-store-with-overload [admission-control]
admission-control/multitenant-fairness/read-heavy/even [admission-control]
admission-control/multitenant-fairness/read-heavy/skewed [admission-control]
admission-control/multitenant-fairness/write-heavy/even [admission-control]
admission-control/multitenant-fairness/write-heavy/skewed [admission-control]
admission-control/row-level-ttl/expired-rows=false [admission-control]
admission-control/row-level-ttl/expired-rows=true [admission-control]
admission-control/snapshot-overload [admission-control]
admission-control/snapshot-overload-io/bandwidth [admission-control]
admission-control/snapshot-overload-io/excise [admission-control]
admission-control/tpcc-olap/nodes=3/cpu=8/w=50/c=96 [admission-control]
admission-control/tpcc-severe-overload [admission-control]
admission/follower-overload/bandwidth [admission-control]
admission/follower-overload/hotspot-no-leases [admission-control]
admission/follower-overload/presplit-control [admission-control]
admission/follower-overload/presplit-no-leases [admission-control]
admission/follower-overload/presplit-with-leases [admission-control]
kv/restart/nodes=12 [admission-control]

On v24.2.4:

admission-control/database-drop [admission-control]
admission-control/disk-bandwidth-limiter [admission-control]
admission-control/elastic-backup [admission-control]
admission-control/elastic-cdc [admission-control]
admission-control/elastic-io [admission-control]
admission-control/index-backfill [admission-control]
admission-control/index-overload [admission-control]
admission-control/intent-resolution [admission-control]
admission-control/multi-store-with-overload [admission-control]
admission-control/multitenant-fairness/read-heavy/even [admission-control]
admission-control/multitenant-fairness/read-heavy/skewed [admission-control]
admission-control/multitenant-fairness/write-heavy/even [admission-control]
admission-control/multitenant-fairness/write-heavy/skewed [admission-control]
admission-control/row-level-ttl/expired-rows=false [admission-control]
admission-control/row-level-ttl/expired-rows=true [admission-control]
admission-control/snapshot-overload [admission-control]
admission-control/snapshot-overload-excise [admission-control]
admission-control/tpcc-olap/nodes=3/cpu=8/w=50/c=96 [admission-control]
admission-control/tpcc-severe-overload [admission-control]
admission/follower-overload/bandwidth [admission-control]
admission/follower-overload/hotspot-no-leases [admission-control]
admission/follower-overload/presplit-control [admission-control]
admission/follower-overload/presplit-no-leases [admission-control]
admission/follower-overload/presplit-with-leases [admission-control]
kv/restart/nodes=12 [admission-control]
kvoli commented 7 hours ago 
admission-control/database-drop [admission-control]                           (enabled)
admission-control/disk-bandwidth-limiter [admission-control]                  (enabled)
admission-control/elastic-backup [admission-control]                          (enabled)
admission-control/elastic-cdc [admission-control]                             (enabled)                              
admission-control/elastic-io [admission-control]                              (enabled) 
admission-control/index-backfill [admission-control]                          (DISABLED)
admission-control/index-overload [admission-control]                          (enabled) 
admission-control/intent-resolution [admission-control]                       (enabled) 
admission-control/multi-store-with-overload [admission-control]               (enabled)
admission-control/multitenant-fairness/read-heavy/even [admission-control]    (enabled)
admission-control/multitenant-fairness/read-heavy/skewed [admission-control]  (enabled)
admission-control/multitenant-fairness/write-heavy/even [admission-control]   (enabled)
admission-control/multitenant-fairness/write-heavy/skewed [admission-control] (enabled)
admission-control/row-level-ttl/expired-rows=false [admission-control]        (enabled)
admission-control/row-level-ttl/expired-rows=true [admission-control]         (enabled)
admission-control/snapshot-overload [admission-control]                       (enabled)
admission-control/snapshot-overload-excise [admission-control]                (enabled)
admission-control/tpcc-olap/nodes=3/cpu=8/w=50/c=96 [admission-control]       (enabled)
admission-control/tpcc-severe-overload [admission-control]                    (enabled)
admission/follower-overload/bandwidth [admission-control]                     (DISABLED)
admission/follower-overload/hotspot-no-leases [admission-control]             (DISABLED)
admission/follower-overload/presplit-control [admission-control]              (DISABLED)
admission/follower-overload/presplit-no-leases [admission-control]            (DISABLED)
admission/follower-overload/presplit-with-leases [admission-control]          (DISABLED)
kv/restart/nodes=12 [admission-control]                                       (enabled)

Brings the list to compare to only:

admission-control/index-backfill [admission-control]                          (DISABLED)
admission/follower-overload/bandwidth [admission-control]                     (DISABLED)
admission/follower-overload/hotspot-no-leases [admission-control]             (DISABLED)
admission/follower-overload/presplit-control [admission-control]              (DISABLED)
admission/follower-overload/presplit-no-leases [admission-control]            (DISABLED)
admission/follower-overload/presplit-with-leases [admission-control]          (DISABLED)