search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.07k stars 3.8k forks source link

kvpb.BatchTimestampBeforeGCError does not contain a stack trace #133569

Open asg0451 opened 2 hours ago

asg0451 commented 2 hours ago

(*kvpb.BatchTimestampBeforeGCError) is not a StackTraceProvider, and in some cases when it surfaces we lack a stack trace completely. This has been observed many times in changefeed failures.

Add stack trace capture to this error.

This should be done in a backportable way, which means no protobuf modifications (?), even if that means doing it in a hackier way to fix the changefeeds' use case (terminal error mark)

Jira issue: CRDB-43690

blathers-crl[bot] commented 2 hours ago

Hi @asg0451, please add branch-* labels to identify which branch(es) this C-bug affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] commented 2 hours ago

cc @cockroachdb/cdc