cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.1k stars 3.8k forks source link

release-24.3: kvcoord: add a metric for number of partial batches in progress #134131

Open blathers-crl[bot] opened 7 hours ago

blathers-crl[bot] commented 7 hours ago

Backport 1/1 commits from #134092 on behalf of @yuzefovich.

/cc @cockroachdb/release


It has been shown that adjusting kv.dist_sender.concurrency_limit cluster setting can improve the performance significantly. We currently already have two relevant counters:

This commit additionally introduces distsender.batches.async.in_progress gauge to indicate how many partial batch are being executed asynchronously at any point in time.

Fixes: #131125.

Release note: None


Release justification: low-risk observability improvement.

blathers-crl[bot] commented 7 hours ago

Thanks for opening a backport.

Please check the backport criteria before merging:

If your backport adds new functionality, please ensure that the following additional criteria are satisfied: - [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way. - [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting). - [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added). - [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules. - [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

blathers-crl[bot] commented 7 hours ago

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

cockroach-teamcity commented 7 hours ago

This change is Reviewable