search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.21k stars 3.82k forks source link

changefeedccl: incorrect metric types #134547

Open asg0451 opened 3 weeks ago

asg0451 commented 3 weeks ago

cockroachdb.changefeed.internal_retry_message is a gauge, but it should be a counter. This causes the datadog integration to be annoying (have to use derivative instead of native rate, and no count available)

changefeed.batch_reduction_count is also affected, and possibly others

Is changing the type of these metrics a breaking change? Can we do it in a way without breaking the datadog integration? I'm not sure.

Jira issue: CRDB-44128

blathers-crl[bot] commented 3 weeks ago

Hi @asg0451, please add branch-* labels to identify which branch(es) this C-bug affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] commented 3 weeks ago

cc @cockroachdb/cdc