cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.18k stars 3.82k forks source link

schemachanger: ALTER TABLE ... RENAME COLUMN doesn't respect statement timeout #134966

Open cockroach-teamcity opened 2 weeks ago

cockroach-teamcity commented 2 weeks ago

pkg/ccl/testccl/sqlccl/sqlccl_test.TestExplainGist failed on release-24.3 @ bca9d708828f2e202df23b343efb8119a610c030:

                                (e'\x1d':::STRING, 'DAF7B780/863AC9AD':::PG_LSN)
                        )
                            AS tab_903 (col_1329, col_1330)
                ),
            with_149 (col_1331)
                AS (
                    SELECT
                        *
                    FROM
                        (VALUES (NULL), (e'\x1a':::STRING), ('C':::STRING), (NULL), ('v':::STRING)) AS tab_904 (col_1331)
                )
        SELECT
            10428:::INT8 AS col_1332,
            (-642835846):::INT8 AS col_1333,
            4401952586723272752:::INT8 AS col_1334,
            (-1.7572401762008667):::FLOAT8 AS col_1335,
            NULL AS col_1336,
            (NULL::INT8 + '1995-06-19':::DATE::DATE)::DATE AS col_1337,
            '1982-04-27 15:57:30.000602':::TIMESTAMP AS col_1338,
            '2022-01-03 05:21:37.000625+00':::TIMESTAMPTZ AS col_1339,
            '32 years 53 days 01:31:49.042009':::INTERVAL AS col_1340,
            false AS col_1341,
            log((-3.914177449839481346E+30):::DECIMAL::DECIMAL)::DECIMAL AS col_1342,
            cte_ref_46.col_1329 AS col_1343,
            NULL AS col_1344,
            'a8c648fa-6e63-489e-a772-50c305650087':::UUID AS col_1345,
            NULL AS col_1346,
            NULL AS col_1347,
            'hello':::greeting AS col_1348
        FROM
            with_148 AS cte_ref_45, with_148 AS cte_ref_46
        WHERE
            false
        ORDER BY
            cte_ref_46.col_1330 DESC, cte_ref_46.col_1329 DESC NULLS LAST
        LIMIT
            91:::INT8;
        UPDATE
            defaultdb.public.seed AS tab_905
        SET
            _string = tab_905._string
        WHERE
            true
        ORDER BY
            tab_905._float8 DESC NULLS FIRST
        LIMIT
            86:::INT8;

    explain_test.go:295: stmt wasn't canceled by statement_timeout of 0.1s - ran at least for 1m: ALTER TABLE defaultdb.public.seed RENAME COLUMN _int2 TO col_1366
    --- FAIL: TestExplainGist/main (73.07s)

Parameters:

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

- #134766 pkg/ccl/testccl/sqlccl/sqlccl_test: TestExplainGist failed [C-test-failure O-robot T-sql-queries branch-master release-blocker]

This test on roachdash | Improve this report!

Jira issue: CRDB-44319

Epic CRDB-43310

annrpom commented 2 weeks ago

Potentially related PRs: https://github.com/cockroachdb/cockroach/pull/128474, https://github.com/cockroachdb/cockroach/pull/126336

Let's try to test this in pkg/sql/run_control_test.go