search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

security: certificate ttl metric is not correctly registered after in-process load #135093

Open angles-n-daemons opened 1 week ago

angles-n-daemons commented 1 week ago

Describe the problem

This bug came out of #130110, the issue is the metrics which are initially created are the ones which are registered. Previously, the values for the metrics was updated, but now the references are changed, despite the old metric references being the ones used by the registry.

What needs to happen is the metrics themselves need to be changed, they either need to close in the container for the certificates or their function needs to be overridden.

Jira issue: CRDB-44362

blathers-crl[bot] commented 1 week ago

Hi @angles-n-daemons, please add branch-* labels to identify which branch(es) this C-bug affects.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.