cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.18k stars 3.82k forks source link

sql: catch panics in virtual table generators #135761

Closed yuzefovich closed 4 days ago

yuzefovich commented 6 days ago

This commit improves the stability of CRDB by introducing the panic-catcher into the goroutine that is spun up for generating the contents of the virtual tables. Previously, if the generator function ran into a panic, this would crash the server, and now instead only the query requiring the contents of the vtable will see an error.

Fixes: #135760.

Release note: None

cockroach-teamcity commented 6 days ago

This change is Reviewable

yuzefovich commented 4 days ago

TFTRs!

bors r+

craig[bot] commented 4 days ago

Build succeeded:

blathers-crl[bot] commented 4 days ago

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #135760: branch-release-23.2, branch-release-24.1, branch-release-24.2.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.