cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

release-24.3: builtins: fix FLOAT4 handling in percentile_cont and percentile_disc #135764

Open blathers-crl[bot] opened 2 days ago

blathers-crl[bot] commented 2 days ago

Backport 1/1 commits from #135130 on behalf of @yuzefovich.

/cc @cockroachdb/release


Previously, we used types.Float.Identical check when working with a couple of aggregate functions and would return an error if FLOAT4 is used. However, our internal implementation is exactly the same (float64), so we can safely use the float type family check instead.

Fixes: #90519.

Release note (bug fix): CockroachDB now correctly evaluates percentile_cont and percentile_disc aggregates over FLOAT4 values (previously we would return an error).


Release justification: bug fix.

blathers-crl[bot] commented 2 days ago

Thanks for opening a backport.

Please check the backport criteria before merging:

If your backport adds new functionality, please ensure that the following additional criteria are satisfied: - [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way. - [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting). - [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added). - [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules. - [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

cockroach-teamcity commented 2 days ago

This change is Reviewable