cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

release-24.3: sql/schemachanger: Correct version gate for ALTER COLUMN TYPE #135816

Closed spilchen closed 1 day ago

spilchen commented 2 days ago

Backport 1/1 commits from #135731.

/cc @cockroachdb/release


Previously, a version gate of 24.2 was applied to certain ALTER COLUMN TYPE operations. For trivial or validation-only changes, support for ALTER COLUMN TYPE in the declarative schema changer was added in PRs

126143 and #127823. However, the wrong version gate was used; these

changes were first introduced in version 24.3.0. This update corrects the version gate to reflect that.

Epic: CRDB-25314 Closes #132523 Release note: none Release justification: low risk bug fix for any one using alter column type in a mixed-mode environment

blathers-crl[bot] commented 2 days ago

Thanks for opening a backport.

Please check the backport criteria before merging:

If your backport adds new functionality, please ensure that the following additional criteria are satisfied: - [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way. - [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting). - [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added). - [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules. - [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

cockroach-teamcity commented 2 days ago

This change is Reviewable