search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

roachtest: refactor and code cleanup in openmetrics emission in roachtests #135821

Closed sambhav-jain-16 closed 2 days ago

sambhav-jain-16 commented 2 days ago
  1. This change aims to refactor exporter.Close() from CreateStatsFileFromExporter to a each roachtest and use defer to make the code more clean and easy to understand.
  2. There were some code smell and nit errors in statsexporter package. This change also fixes those.

Epic: none

Release note: None

cockroach-teamcity commented 2 days ago

This change is Reviewable

sambhav-jain-16 commented 2 days ago

Test run for the changes: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/17857222?hideProblemsFromDependencies=false&hideTestsFromDependencies=false