cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

release-24.3: sqlstats: stats flush should honor stopper quiesce #135835

Closed blathers-crl[bot] closed 1 day ago

blathers-crl[bot] commented 1 day ago

Backport 1/1 commits from #135336 on behalf of @dhartunian.

/cc @cockroachdb/release


Previously, the sql stats flush async tasks would continue potentially long blocks of work during stopper quiescence. This change helps them cancel mid-flush when the stopper is quiescing for orderly shutdown.

Resolves: https://github.com/cockroachdb/cockroach/issues/133106 Epic: None

Release note: None


Release justification:

blathers-crl[bot] commented 1 day ago

Thanks for opening a backport.

Please check the backport criteria before merging:

If your backport adds new functionality, please ensure that the following additional criteria are satisfied: - [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way. - [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting). - [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added). - [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules. - [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

blathers-crl[bot] commented 1 day ago

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

cockroach-teamcity commented 1 day ago

This change is Reviewable