search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

kvclient: introduce an independent knob to reject large write transactions #135841

Open arulajmani opened 1 day ago

arulajmani commented 1 day ago

Describe the problem

Currently, the only way to reject large write transactions is kv.transaction.reject_over_max_intents_budget.enabled, which rejects any transaction that goes over the kv.transaction.max_intents_bytes tracking limit. It's not great that these settings are always tied together [1].

We should introduce a new cluster setting to reject large writing transactions that isn't tied to the kv.transaction.max_intents_bytes cluster setting.

Jira issue: CRDB-44747

andrewbaptist commented 21 hours ago

@arulajmani I'm adding a new setting that is completely independent of kv.transaction.reject_over_max_intents_budget.enabled and kv.transaction.max_intents_bytes for now. I'm going to update the node on kv.transaction.reject_over_max_intents_budget.enabled to recommend against using it.

arulajmani commented 14 hours ago

Sounds good @andrewbaptist. I'll assign the issue to you in that case.