cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.16k stars 3.82k forks source link

release-24.3: sql: add observability statements for triggers #135862

Open blathers-crl[bot] opened 1 day ago

blathers-crl[bot] commented 1 day ago

Backport 2/2 commits from #135778 on behalf of @DrewKimball.

/cc @cockroachdb/release


sql: add statement to display the triggers on a table

This commit adds support for SHOW TRIGGERS FROM <tablename>, which displays the name of each trigger defined on the given table, as well as whether that trigger is enabled.

Informs #128368

Release note (sql change): Added support for SHOW TRIGGERS, which displays the names of all triggers on a table, as well as whether each trigger is enabled. The user must have any privilege on the table, or be its owner.

sql: add statement to display the CREATE statement for a trigger

This commit adds support for SHOW CREATE TRIGGER, which displays the decompiled CREATE statement for a trigger, and which can be used to recreate an equivalent trigger. The syntax looks like this:

SHOW CREATE TRIGGER <triggername> ON <tablename>

Fixes #128368

Release note (sql change): Added support for SHOW CREATE TRIGGER, which displays the CREATE statement for a trigger. The user must have any privilege on the table, or be its owner.


Release justification: observability improvement for new functionality in 24.3

blathers-crl[bot] commented 1 day ago

Thanks for opening a backport.

Please check the backport criteria before merging:

If your backport adds new functionality, please ensure that the following additional criteria are satisfied: - [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way. - [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting). - [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added). - [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules. - [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

cockroach-teamcity commented 1 day ago

This change is Reviewable