search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.1k stars 3.81k forks source link

acceptance/terrafarm: broken control-C behavior #17906

Closed cuongdo closed 7 years ago

cuongdo commented 7 years ago

Recent changes have made the behavior of control-C much worse. After a nightly test has created all its Azure resources, pressing control-C used to reliably destroy Azure resources. Now, control-C often quits the test without cleaning up.

cuongdo commented 7 years ago

Actually, the destroy does seem to work now (not sure why). The thing that's consistently broken is when -tf.keep-cluster=failed or -tf.keep-cluster=always are specified. In both of those cases, the Farmer is supposed to output the command-line to destroy the cluster. However, it's not doing that any more.