roachtest: port terrafarm nightly tests to roachtest

[petermattis]

Tracking issue for porting terrafarm-based nightly tests to roachtest.

• [x] TestRebalance_3To5Small
• [x] TestRebalance_3To5Small_WithSchemaChanges
• [x] TestSteady_3Small
• [x] TestSteady_6Medium
• [x] TestUpreplicate_1To6Medium
• [x] TestContinuousLoad_BlockWriter
• [x] TestContinuousLoad_Photos
• [x] BenchmarkRestoreBig
• [x] BenchmarkRestoreTPCH10/numNodes={1,3,10}
• [x] BenchmarkBackup2TB
• [x] BenchmarkRestore2TB

[danhhz]

TestContinuousLoad_BlockWriter does the same thing as the two kv tests in Workload Nightly, so I think we can check that one. TestContinuousLoad_Photos should be easy to add once we have a workload impl of photos

[danhhz]

Ported BenchmarkRestore2TB in https://github.com/cockroachdb/cockroach/pull/22859 (forgot to link this issue there). I don't think either of BenchmarkRestoreBig or BenchmarkRestoreTPCH10 are really pulling their weight, so I'm going to skip both of them unless someone objects

[benesch]

No objections. I say delete them outright! 🔨

On Tue, Feb 20, 2018 at 4:51 PM, Daniel Harrison notifications@github.com wrote:

Ported BenchmarkRestore2TB in #22859 https://github.com/cockroachdb/cockroach/pull/22859 (forgot to link this issue there). I don't think either of BenchmarkRestoreBig or BenchmarkRestoreTPCH10 are really pulling their weight, so I'm going to skip both of them unless someone objects

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/cockroachdb/cockroach/issues/22646#issuecomment-367132318, or mute the thread https://github.com/notifications/unsubscribe-auth/AA15IL9rfyzHwZEbBJxjCCi2a3zgS4Pjks5tWz5GgaJpZM4SEG1b .

[petermattis]

Do we want to bother porting photos to workload? TPC-C seems like a better workload.

[danhhz]

Agreed. I'll skip that one too

[danhhz]

Okay, the only one left is the schema change one. @vivekmenezes just to confirm, do we think that's still useful and worth porting?

[petermattis]

I'm not familiar with the details of the existing schema change test, but we definitely want a nightly schema change test.

[vivekmenezes]

@danhhz yes that's a super useful test! Thanks

[rjnn]

@danhhz it appears you have done all the tasks for this issue, save closing it. Can you please confirm and close?

[benesch]

I think there's one final task: removing the old Terraform tests. Dan did all the hard work here so I don't want to spoil his fun. Punting out of 2.0 in the meantime, though.