Closed cockroach-teamcity closed 6 years ago
I'm just gonna assume this should be assigned to you.
SHA: https://github.com/cockroachdb/cockroach/commits/dbf5d6ed987c2c240bcbf0bb2b514c8e2186f855
Parameters:
TAGS=
GOFLAGS=-race
To repro, try:
# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stressrace instead of stress and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
make stress TESTS=TestSplitAt PKG=github.com/cockroachdb/cockroach/pkg/sql TESTTIMEOUT=5m STRESSFLAGS='-stderr=false -maxtime 20m -timeout 10m'
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=865673&tab=buildLog
I'm seeing this frequently in CI runs right now.
Reproduces with: make stress PKG=./sql TESTS=TestSplitAt TESTTIMEOUT=1m
. Not sure if that timeout is fair, though the test runs in ~0.3s without stress. Instrumentation shows that it is hanging on the very first test case: ALTER TABLE d.t SPLIT AT VALUES (2, 'b')
. Logs show:
I180830 14:23:57.227447 39 sql/split_test.go:132 0: running: ALTER TABLE d.t SPLIT AT VALUES (2, 'b')
I180830 14:23:57.228020 675 storage/replica_command.go:298 [n1,s1,r27/1:/Table/5{3/1/1/"a"-4}] initiating a split of this range at key /Table/53/1/2/"b" [r28]
...
And then not much else. Goroutine 675 has a beast of a stack:
goroutine 675 [select]:
github.com/cockroachdb/cockroach/pkg/storage.(*Store).Send(0xc4207ce580, 0x65a44e0, 0xc4213e55f0, 0x154faf9175331855, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0xc421243400, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/store.go:3179 +0xd93
github.com/cockroachdb/cockroach/pkg/storage.(*Stores).Send(0xc4206984d0, 0x65a44e0, 0xc4213e5590, 0x0, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0xc421243400, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/stores.go:185 +0xdb
github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal.func1(0x65a44e0, 0xc4213e5590, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:1006 +0x19a
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunTaskWithErr(0xc42058ed80, 0x65a44e0, 0xc4213e5590, 0x607b306, 0x10, 0xc4211438f0, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:303 +0xed
github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal(0xc420511180, 0x65a44e0, 0xc4213e5590, 0xc4213ee700, 0xc4213e5590, 0x0, 0xc421143b78)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:993 +0x201
github.com/cockroachdb/cockroach/pkg/server.(*Node).Batch(0xc420511180, 0x65a44e0, 0xc4213e5590, 0xc4213ee700, 0x0, 0xc421143bf0, 0x4126f4c)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:1034 +0x9c
github.com/cockroachdb/cockroach/pkg/rpc.internalClientAdapter.Batch(0x65842a0, 0xc420511180, 0x65a44e0, 0xc4213e5560, 0xc4213ee700, 0x0, 0x0, 0x0, 0xc420f72ed0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/rpc/context.go:375 +0x4f
github.com/cockroachdb/cockroach/pkg/kv.(*grpcTransport).sendBatch(0xc4213e5530, 0x65a44e0, 0xc4213e5560, 0x6588960, 0xc420267c30, 0x0, 0x0, 0x100000001, 0x1, 0x1b, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/transport.go:199 +0x138
github.com/cockroachdb/cockroach/pkg/kv.(*grpcTransport).SendNext(0xc4213e5530, 0x65a44e0, 0xc420f72ed0, 0x0, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0xc421243400, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/transport.go:169 +0x138
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendToReplicas(0xc420540900, 0x65a44e0, 0xc420f72ed0, 0xc420540950, 0x1b, 0xc4203df4a0, 0x1, 0x1, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:1303 +0x30a
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendRPC(0xc420540900, 0x65a44e0, 0xc420f72ed0, 0x1b, 0xc4203df4a0, 0x1, 0x1, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:387 +0x252
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendSingleRange(0xc420540900, 0x65a44e0, 0xc420f72ed0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421243400, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:454 +0x227
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendPartialBatch(0xc420540900, 0x65a44e0, 0xc420f72ed0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421243400, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:1080 +0x322
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).divideAndSendBatchToRanges(0xc420540900, 0x65a44e0, 0xc420f72ed0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421243400, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:903 +0x88b
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).Send(0xc420540900, 0x65a44e0, 0xc420f72ed0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:668 +0x4c7
github.com/cockroachdb/cockroach/pkg/kv.(*txnLockGatekeeper).SendLocked(0xc4204bdfc0, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_coord_sender.go:232 +0xf5
github.com/cockroachdb/cockroach/pkg/kv.(*txnMetrics).SendLocked(0xc4204bdf88, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_metrics.go:57 +0x115
github.com/cockroachdb/cockroach/pkg/kv.(*txnSpanRefresher).sendLockedWithRefreshAttempts(0xc4204bdef0, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_span_refresher.go:153 +0x98
github.com/cockroachdb/cockroach/pkg/kv.(*txnSpanRefresher).SendLocked(0xc4204bdef0, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_span_refresher.go:105 +0x11e
github.com/cockroachdb/cockroach/pkg/kv.(*txnPipeliner).SendLocked(0xc4204bde70, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_pipeliner.go:161 +0x165
github.com/cockroachdb/cockroach/pkg/kv.(*txnIntentCollector).SendLocked(0xc4204bde30, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_intent_collector.go:106 +0x45d
github.com/cockroachdb/cockroach/pkg/kv.(*txnSeqNumAllocator).SendLocked(0xc4204bdf70, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_sequence_nums.go:68 +0x246
github.com/cockroachdb/cockroach/pkg/kv.(*txnHeartbeat).SendLocked(0xc4204bdd98, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_interceptor_heartbeat.go:219 +0x53f
github.com/cockroachdb/cockroach/pkg/kv.(*TxnCoordSender).Send(0xc4204bdc00, 0x65a44e0, 0xc420f72e40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc421453600, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn_coord_sender.go:600 +0x537
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).sendUsingSender(0xc420706400, 0x65a44e0, 0xc420ef2720, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:613 +0x135
github.com/cockroachdb/cockroach/pkg/internal/client.(*Txn).Send(0xc42141d720, 0x65a44e0, 0xc420ef2720, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/txn.go:797 +0x161
github.com/cockroachdb/cockroach/pkg/internal/client.(*Txn).Send-fm(0x65a44e0, 0xc420ef2720, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/txn.go:504 +0x83
github.com/cockroachdb/cockroach/pkg/internal/client.sendAndFill(0x65a44e0, 0xc420ef2720, 0xc4211468b8, 0xc4215dca00, 0x40, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:538 +0x108
github.com/cockroachdb/cockroach/pkg/internal/client.(*Txn).Run(0xc42141d720, 0x65a44e0, 0xc420ef2720, 0xc4215dca00, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/txn.go:504 +0xc7
github.com/cockroachdb/cockroach/pkg/storage.(*Replica).adminSplitWithDescriptor.func1(0x65a44e0, 0xc420ef2720, 0xc42141d720, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/replica_command.go:369 +0x5bd
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).Txn.func1(0x65a44e0, 0xc420ef2720, 0xc42141d720, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:576 +0x43
github.com/cockroachdb/cockroach/pkg/internal/client.(*Txn).exec(0xc42141d720, 0x65a44e0, 0xc420ef2720, 0xc420467820, 0xc420ef2720, 0x1)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/txn.go:692 +0xe6
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).Txn(0xc420706400, 0x65a44e0, 0xc420ef2720, 0xc420ef2780, 0xc421146e80, 0x2)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:575 +0xd1
github.com/cockroachdb/cockroach/pkg/storage.(*Replica).adminSplitWithDescriptor(0xc42134a700, 0x65a44e0, 0xc420ef2720, 0xc420276ed0, 0x7, 0x8, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/replica_command.go:301 +0x92a
github.com/cockroachdb/cockroach/pkg/storage.(*Replica).AdminSplit(0xc42134a700, 0x65a44e0, 0xc420ef2720, 0xc420276ed0, 0x7, 0x8, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/replica_command.go:171 +0x280
github.com/cockroachdb/cockroach/pkg/storage.(*Replica).executeAdminBatch(0xc42134a700, 0x65a44e0, 0xc420ef2720, 0x154faf91753287f3, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/replica.go:2668 +0xba4
github.com/cockroachdb/cockroach/pkg/storage.(*Replica).sendWithRangeID(0xc42134a700, 0x65a44e0, 0xc420ef2720, 0x1b, 0x154faf91753287f3, 0x0, 0x100000001, 0x1, 0x1b, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/replica.go:2028 +0x653
github.com/cockroachdb/cockroach/pkg/storage.(*Replica).Send(0xc42134a700, 0x65a44e0, 0xc420ef26f0, 0x154faf91753287f3, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/replica.go:1970 +0x90
github.com/cockroachdb/cockroach/pkg/storage.(*Store).Send(0xc4207ce580, 0x65a44e0, 0xc420ef26f0, 0x154faf91753287f3, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/store.go:3089 +0x606
github.com/cockroachdb/cockroach/pkg/storage.(*Stores).Send(0xc4206984d0, 0x65a44e0, 0xc420ef2690, 0x0, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/storage/stores.go:185 +0xdb
github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal.func1(0x65a44e0, 0xc420ef2690, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:1006 +0x19a
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunTaskWithErr(0xc42058ed80, 0x65a44e0, 0xc420ef2690, 0x607b306, 0x10, 0xc421148028, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:303 +0xed
github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal(0xc420511180, 0x65a44e0, 0xc420ef2690, 0xc420e93d00, 0xc420ef2690, 0x402d0e9, 0x61ac130)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:993 +0x201
github.com/cockroachdb/cockroach/pkg/server.(*Node).Batch(0xc420511180, 0x65a44e0, 0xc420ef2690, 0xc420e93d00, 0x0, 0xc421148328, 0x4126f4c)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:1034 +0x9c
github.com/cockroachdb/cockroach/pkg/rpc.internalClientAdapter.Batch(0x65842a0, 0xc420511180, 0x65a44e0, 0xc420ef2660, 0xc420e93d00, 0x0, 0x0, 0x0, 0xc420ef25a0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/rpc/context.go:375 +0x4f
github.com/cockroachdb/cockroach/pkg/kv.(*grpcTransport).sendBatch(0xc420ef2630, 0x65a44e0, 0xc420ef2660, 0x6588960, 0xc420267c30, 0x0, 0x0, 0x100000001, 0x1, 0x1b, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/transport.go:199 +0x138
github.com/cockroachdb/cockroach/pkg/kv.(*grpcTransport).SendNext(0xc420ef2630, 0x65a44e0, 0xc420ef25a0, 0x0, 0x0, 0x100000001, 0x1, 0x1b, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/transport.go:169 +0x138
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendToReplicas(0xc420540900, 0x65a44e0, 0xc420ef25a0, 0xc420540950, 0x1b, 0xc4203aa940, 0x1, 0x1, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:1303 +0x30a
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendRPC(0xc420540900, 0x65a44e0, 0xc420ef25a0, 0x1b, 0xc4203aa940, 0x1, 0x1, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:387 +0x252
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendSingleRange(0xc420540900, 0x65a44e0, 0xc420ef25a0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:454 +0x227
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).sendPartialBatch(0xc420540900, 0x65a44e0, 0xc420ef25a0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:1080 +0x322
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).divideAndSendBatchToRanges(0xc420540900, 0x65a44e0, 0xc420ef25a0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:756 +0x1364
github.com/cockroachdb/cockroach/pkg/kv.(*DistSender).Send(0xc420540900, 0x65a44e0, 0xc420ef25a0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/kv/dist_sender.go:668 +0x4c7
github.com/cockroachdb/cockroach/pkg/internal/client.(*CrossRangeTxnWrapperSender).Send(0xc420706460, 0x65a44e0, 0xc420ef2480, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:213 +0xc1
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).sendUsingSender(0xc420706400, 0x65a44e0, 0xc420ef2480, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:613 +0x135
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).send(0xc420706400, 0x65a44e0, 0xc420ef2480, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:595 +0xa4
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).(github.com/cockroachdb/cockroach/pkg/internal/client.send)-fm(0x65a44e0, 0xc420ef2480, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:561 +0x83
github.com/cockroachdb/cockroach/pkg/internal/client.sendAndFill(0x65a44e0, 0xc420ef2480, 0xc421149bd0, 0xc42163ee00, 0xc420276ed0, 0xc420276ed0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:538 +0x108
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).Run(0xc420706400, 0x65a44e0, 0xc420ef2480, 0xc42163ee00, 0xc4203aa8c0, 0x1)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:561 +0x94
github.com/cockroachdb/cockroach/pkg/internal/client.(*DB).AdminSplit(0xc420706400, 0x65a44e0, 0xc420ef2480, 0x5cc79c0, 0xc4203aa8a0, 0x5cc79c0, 0xc4203aa8c0, 0x8, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/internal/client/db.go:476 +0x98
github.com/cockroachdb/cockroach/pkg/sql.(*splitNode).Next(0xc420f3bbc0, 0x65a44e0, 0xc420ef2480, 0xc42142bdc0, 0xc421598a38, 0x0, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/split.go:130 +0x229
github.com/cockroachdb/cockroach/pkg/sql.(*planNodeToRowSource).Next(0xc42167a000, 0xc421598a38, 0x6598160, 0xc420f3bbc0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan_node_to_row_source.go:189 +0x5d3
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun.Run(0x65a44e0, 0xc420ef2480, 0x65ad160, 0xc42167a000, 0x6584860, 0xc42034d880)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/base.go:170 +0x35
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun.(*ProcessorBase).Run(0xc42167a000, 0x65a44e0, 0xc420ef2480, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:731 +0x98
github.com/cockroachdb/cockroach/pkg/sql/distsqlrun.(*Flow).StartSync(0xc4213121c0, 0x65a44e0, 0xc420ef2480, 0x61a6940, 0xc420ee6540, 0x6584420)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/flow.go:594 +0x191
github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Run(0xc420c93600, 0xc420f3bc20, 0xc42141c8c0, 0xc42114a808, 0xc421492500, 0xc421598ad0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:245 +0x879
github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRun(0xc420c93600, 0x65a44e0, 0xc420f10f90, 0xc421598ad0, 0xc420f3bc20, 0xc42141c8c0, 0x6598160, 0xc420f3bbc0, 0xc421492500)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:737 +0x24c
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithDistSQLEngine(0xc421598600, 0x65a44e0, 0xc420f10f90, 0xc421598a38, 0x3, 0x9babad8, 0xc4213db050, 0x0, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:966 +0x2d8
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine(0xc421598600, 0x65a44e0, 0xc420f10f90, 0x65a7fe0, 0xc4203aa040, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:808 +0x688
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState(0xc421598600, 0x65a44e0, 0xc420f10f90, 0x65a7fe0, 0xc4203aa040, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:401 +0xb82
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt(0xc421598600, 0x65a44e0, 0xc420f10f90, 0x65a7fe0, 0xc4203aa040, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:95 +0x358
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run(0xc421598600, 0x65a4420, 0xc420860bc0, 0xc42030e4e0, 0x0, 0x0)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1079 +0x2186
github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn(0xc42051c240, 0x65a4420, 0xc420860bc0, 0x0, 0x0, 0xc42146c04a, 0x4, 0x0, 0x0, 0x6587720, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:416 +0x1bb
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func3(0xc42051c240, 0x65a4420, 0xc420860bc0, 0xc421095340, 0x5400, 0x15000, 0xc420130840, 0xc42030e4e0, 0xc42030e4d0, 0xc420377a10, ...)
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:267 +0x122
created by github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl
/Users/pmattis/Development/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:266 +0xf04
Heh, I wonder if things like splitNode
should force an async path in client.DB
to avoid these giant stacks... it's not clear to me whether it's okay that the SQL goroutines end up being involved in stuff like this.
Goroutine 675 is blocked on the following code:
// A merge was in progress. We need to retry the command after the merge
// completes, as signaled by the closing of the replica's mergeComplete
// channel. Note that the merge may have already completed, in which case
// its mergeComplete channel will be nil.
mergeCompleteCh := repl.getMergeCompleteCh()
if mergeCompleteCh != nil {
select {
case <-mergeCompleteCh:
// Merge complete. Retry the command.
case <-ctx.Done():
return nil, roachpb.NewError(ctx.Err())
case <-s.stopper.ShouldQuiesce():
return nil, roachpb.NewError(&roachpb.NodeUnavailableError{})
}
}
So definitely seems to be an @benesch issue. This is sort of interesting because the merge queue is disabled at this point.
I’m hopeful this is the issue that’s fixed in https://github.com/cockroachdb/cockroach/pull/29324. Unfortunately I’m on the road right now so can’t fix. Apologies for the disruption. Mind plumbing in a t.Skip for now?
Not surprising to see the issue crop up here. This test manually turns on the merge queue.
On Thu, Aug 30, 2018 at 10:31 AM Peter Mattis notifications@github.com wrote:
Goroutine 675 is blocked on the following code:
// A merge was in progress. We need to retry the command after the merge // completes, as signaled by the closing of the replica's mergeComplete // channel. Note that the merge may have already completed, in which case // its mergeComplete channel will be nil. mergeCompleteCh := repl.getMergeCompleteCh() if mergeCompleteCh != nil { select { case <-mergeCompleteCh: // Merge complete. Retry the command. case <-ctx.Done(): return nil, roachpb.NewError(ctx.Err()) case <-s.stopper.ShouldQuiesce(): return nil, roachpb.NewError(&roachpb.NodeUnavailableError{}) } }
So definitely seems to be an @benesch https://github.com/benesch issue. This is sort of interesting because the merge queue is disabled at this point.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cockroachdb/cockroach/issues/29169#issuecomment-417340518, or mute the thread https://github.com/notifications/unsubscribe-auth/AA15INIbvUstPG2QwFGOwV4prxMnPIqvks5uV_c4gaJpZM4WO9Qw .
Let me see if the failure reproduces on #29324...nope.
I'll send a PR to skip this test for now. You can re-enable it in #29324.
SHA: https://github.com/cockroachdb/cockroach/commits/dbf5d6ed987c2c240bcbf0bb2b514c8e2186f855
Parameters:
To repro, try:
Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=865443&tab=buildLog