cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.07k stars 3.8k forks source link

roachtest: don't notify slack about parent test failures #30800

Closed petermattis closed 6 years ago

petermattis commented 6 years ago

A recent slack message about the nightly roachtest summary showed:

Failures [unstable]
jepsen/2
jepsen/2/g2
jepsen/2/g2/majority-ring
jepsen/3
jepsen/3/register
jepsen/3/register/split

We shouldn't be including the "parent" tests (jepsen/2, jepsen/2/g2, jepsen/3 and jepsen/3/register) in this message.

petermattis commented 6 years ago

Part of this is easy to fix, but the fix will mess up the count of skipped tests. Interestingly, that count appears to be broken already as the queue/nodes=1 test is skipped but is showing up as success.