cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.72k stars 3.75k forks source link

sql: support for adminer #40391

Open awoods187 opened 4 years ago

awoods187 commented 4 years ago

adminer Version: 4.7.2 A custer received an error trying to list tables in the database.

Compared to pgsql (https://github.com/cockroachdb/cockroach/issues/40390), at least adminer list all the databases.

The customer received this error: image

Blocked by #86017

Jira issue: CRDB-5540

gnat commented 1 year ago

After using many tools with CockroachDB, Adminer is honestly one of the better ones by a wide margin (all you need is php -S localhost:8888 -t adminer to run it, even directly off of a server, and it's just a standalone all-in-one php file). Works if you comment out this part of the query at: https://github.com/vrana/adminer/blob/88647b93e467210f270340e758af6771e2c5638a/adminer/drivers/pgsql.inc.php#L325

It's such a small modification to the Postgres driver to have it work, I would submit a PR but @vrana hasn't merged any PR's for quite some time, sadly. :eyes: Hope he's okay!

Ideally, would love to see a similar UI just built into CockroachDB's web UI, but Adminer is definitely underrated.

gnat commented 1 year ago

Uploaded my branch that works with CockroachDB, based on the Postgres driver.

Not sure if I'll be able to allocate time to polish it, but it was only a few changes to make it mostly functional.

https://github.com/vrana/adminer/pull/461

Would love to just see something like adminer for table creation / browsing built into the Cockroach UI.